Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AReaL project's documentation by introducing full multi-language support. The changes involve a major restructuring of the documentation directory, the addition of Chinese translations for all key guides and references, and the implementation of interactive features for language switching. This initiative aims to make the project's extensive documentation accessible to a wider, global audience, fostering broader adoption and understanding of AReaL's capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a major update to the documentation by adding support for Chinese translations. This includes restructuring the docs directory, adding a language toggle button with corresponding CSS and JavaScript, and providing a build script for multi-language documentation. A significant number of English documentation files have been moved, and their Chinese translations have been added. The CLI documentation generator has also been updated to support multiple languages.
The changes are well-structured and the implementation of the new features appears solid. I have a few minor suggestions to improve the robustness and readability of the new JavaScript code for the language toggle.
- Add lang-toggle.js and lang-toggle.css to en/zh _static directories - Update _config.yml to reference correct paths - Modify build_all.sh to copy static files and figures - Fix URL redirect logic (remove trailing slash) - Style button with translate icon, gray theme matching nav icons - Dynamically adjust icon size based on existing header icons
- Add lang-toggle.js and lang-toggle.css to en/zh _static directories - Update _config.yml to reference correct paths - Modify build_all.sh to copy static files and figures - Fix URL redirect logic (remove trailing slash) - Style button with translate icon, gray theme matching nav icons - Dynamically adjust icon size based on existing header icons
…into add_chinese_doc
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Code Review: PR #969 — feat: Add Chinese docThanks for the multi-language documentation work! Below are findings from a detailed review, grouped by severity. Issues are numbered for easy reference. 🔴 CRITICALIssue 1: LaTeX Math Formulas Systematically Corrupted (77+ instances)Files: All
Example from This is likely caused by mdformat running on LaTeX content. MathJax/KaTeX will receive Fix: Revert all LaTeX to original single-backslash form. Consider excluding math blocks from markdown formatting. 🟠 HIGHIssue 2: Conflicting Dependency Install — pip vs uvFile: The workflow installs # Current (redundant):
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install --upgrade jupyter-book==1.0.4.post1Fix: Replace with Issue 3:
|
| Severity | Count | Blocking? |
|---|---|---|
| CRITICAL | 1 (77+ instances) | ✅ Yes |
| HIGH | 5 | ✅ Yes |
| MEDIUM | 6 | Recommended |
| LOW | 4 | Nice-to-have |
Issue 1 (LaTeX corruption) is a merge blocker — it renders all algorithm documentation math unreadable. Issues 2-6 should also be addressed before merge.
|
Done |
|
ignore issue 1/2, it is LLM hallucination |
There was a problem hiding this comment.
This file should be reverted.
| @@ -43,15 +46,17 @@ jobs: | |||
|
|
|||
There was a problem hiding this comment.
should use uv, as mentioned above
There was a problem hiding this comment.
The current CI workflow has a pinned jupyter-book version installed via pure pip:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install --upgrade jupyter-book==1.0.4.post1
However, we should use uv sync --only-dev to install the jupyterbook specified in pyproject.toml. (Or you should change pyproject.toml to pin the version as well.) This is for the integrity of the project. The environment for building docs should be the same in CI and in a locally installed environment.
There was a problem hiding this comment.
yes make sense, wait..

Support Multi-languadge
See demo:
https://ziyitsang.github.io/AReaLAuto-remember user's language and replay when browsed again
Type of Change
work as expected)
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
Additional Context
Need help? Check the Contributing Guide or ask in
GitHub Discussions!