docs: improve documentation for problem generation scripts (#9)#13
Conversation
…AI#9) - Add header comments to problem_generation.sh explaining BASE_SEED, N_RUNS, and Python script parameters - Add module docstrings to infer_split_merge.py and deduplicate_problems.py - Add comprehensive help text to all argparse arguments - Document end-exclusive range behavior in --indices parameter - Add usage examples in deduplicate_problems.py epilog This commit addresses issue inclusionAI#9 by adding comprehensive documentation to the problem generation pipeline scripts. Fixes inclusionAI#9
Summary of ChangesHello @pi-dal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for the problem generation pipeline scripts. It introduces clear explanations for script parameters, module functionalities, and command-line arguments, making the scripts much more accessible and easier to use for both new and existing contributors. The improvements aim to reduce the learning curve and prevent common misunderstandings regarding script behavior and expected inputs/outputs. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly improves the documentation and usability of the problem generation scripts. The addition of module-level docstrings, detailed argparse help texts, and explanatory comments in the shell script are all excellent changes that make the tools much easier to understand and use. My review includes one minor suggestion to further improve the clarity of the configuration section in problem_generation.sh.
|
|
||
| # Problem generation pipeline: run multiple inference seeds, then merge + deduplicate. | ||
| # | ||
| # Knobs: |
There was a problem hiding this comment.
The term 'Knobs' is a bit informal and could be ambiguous. Since these values are hardcoded and need to be manually edited in the script, it would be clearer to explicitly state that they are configurable by editing the script. Consider a more descriptive header for this section to improve clarity for future users.
| # Knobs: | |
| # Configuration (edit variables below): |
Summary
problem_generation.shexplaining script parameters (BASE_SEED,N_RUNS) and Python script parametersinfer_split_merge.pyanddeduplicate_problems.pyhelptext to all argparse arguments--indices)deduplicate_problems.pyFiles Changed
problem_generation.sh: Added header documentation explaining the pipeline, knobs, and notesinfer_split_merge.py: Added module docstring and comprehensive argparse documentationdeduplicate_problems.py: Added module docstring, argparse documentation with usage examplesMotivation
The problem generation scripts lacked documentation, making it difficult for new users to understand:
This change improves usability by providing inline documentation that users can access via:
--helpflagCloses #9