Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new blog post introducing Ming-Omni-TTS, an innovative unified audio generation model. The post highlights the model's advanced capabilities in fine-grained speech control, zero-shot voice design, and its unique ability to generate speech, music, and environmental sounds simultaneously. It also emphasizes the model's efficiency and its capacity to handle complex text normalization, making it a versatile tool for various audio synthesis applications. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds two new blog posts, one in English and one in Chinese, for Ming-Omni-TTS. The changes introduce the model, its features, and various examples. My review focuses on improving consistency and accessibility in the markdown files. I've suggested changes to link behavior, header formatting, image alt texts, and translation consistency.
Note: Security Review has been skipped due to the limited scope of the PR.
| show_word_count: true | ||
| --- | ||
|
|
||
| {{< button href="https://github.com/inclusionAI/Ming-omni-tts" label="GITHUB" external=true >}} 🤗 <a href="https://huggingface.co/inclusionAI/Ming-omni-tts-0.5B">Hugging Face</a>| 🤖 <a href="https://modelscope.cn/models/inclusionAI/Ming-omni-tts-0.5B">ModelScope</a> |
There was a problem hiding this comment.
The GitHub link opens in a new tab, but the Hugging Face and ModelScope links do not. For a consistent user experience, all external links should open in a new tab. Please add target="_blank" to the other links. It's also a good security practice to add rel="noopener noreferrer" when using target="_blank".
| {{< button href="https://github.com/inclusionAI/Ming-omni-tts" label="GITHUB" external=true >}} 🤗 <a href="https://huggingface.co/inclusionAI/Ming-omni-tts-0.5B">Hugging Face</a>| 🤖 <a href="https://modelscope.cn/models/inclusionAI/Ming-omni-tts-0.5B">ModelScope</a> | |
| {{< button href="https://github.com/inclusionAI/Ming-omni-tts" label="GITHUB" external=true >}} 🤗 <a href="https://huggingface.co/inclusionAI/Ming-omni-tts-0.5B" target="_blank" rel="noopener noreferrer">Hugging Face</a>| 🤖 <a href="https://modelscope.cn/models/inclusionAI/Ming-omni-tts-0.5B" target="_blank" rel="noopener noreferrer">ModelScope</a> |
content/blog/ming-omni-tts/index.md
Outdated
| ### Unified Continuous Audio Tokenizer. | ||
| <img width="1034" alt="结构图" src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/W3RqRLQx8DEAAAAAUDAAAAgADvHDAQFr/original" /> | ||
|
|
||
| ### Unified Audio Language Model for Speech, Music and Sound Generation. | ||
| <img width="1034" alt="结构图" src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/oop7QJpDNdIAAAAAV1AAAAgADvHDAQFr/original" /> |
There was a problem hiding this comment.
For consistency with other headers in the document, the trailing periods should be removed from the headers on lines 33 and 36. Additionally, the alt text for the images should be in English for accessibility in an English document. A more descriptive alt text is also recommended.
| ### Unified Continuous Audio Tokenizer. | |
| <img width="1034" alt="结构图" src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/W3RqRLQx8DEAAAAAUDAAAAgADvHDAQFr/original" /> | |
| ### Unified Audio Language Model for Speech, Music and Sound Generation. | |
| <img width="1034" alt="结构图" src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/oop7QJpDNdIAAAAAV1AAAAgADvHDAQFr/original" /> | |
| ### Unified Continuous Audio Tokenizer | |
| <img width="1034" alt="Diagram of the Unified Continuous Audio Tokenizer architecture." src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/W3RqRLQx8DEAAAAAUDAAAAgADvHDAQFr/original" /> | |
| ### Unified Audio Language Model for Speech, Music and Sound Generation | |
| <img width="1034" alt="Diagram of the Unified Audio Language Model for Speech, Music and Sound Generation architecture." src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/oop7QJpDNdIAAAAAV1AAAAgADvHDAQFr/original" /> |
There was a problem hiding this comment.
alt 类型的内容对于 SEO 这些很重要,建议修改
content/blog/ming-omni-tts/index.md
Outdated
| <img width="1034" alt="结构图" src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/oop7QJpDNdIAAAAAV1AAAAgADvHDAQFr/original" /> | ||
|
|
||
| ## Benchmark Evaluations | ||
| <img width="1034" alt="结构图" src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/GBiVQ7tR2I4AAAAAdhAAAAgADvHDAQFr/original" /> |
There was a problem hiding this comment.
The alt text for the image should be in English for accessibility in an English document. A more descriptive alt text related to the section 'Benchmark Evaluations' is recommended.
| <img width="1034" alt="结构图" src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/GBiVQ7tR2I4AAAAAdhAAAAgADvHDAQFr/original" /> | |
| <img width="1034" alt="Table showing benchmark evaluation results." src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/img/GBiVQ7tR2I4AAAAAdhAAAAgADvHDAQFr/original" /> |
There was a problem hiding this comment.
alt 内容对于 SEO 类型很重要,建议修改,目前这种写法的确不是很专业
| show_word_count: true | ||
| --- | ||
|
|
||
| {{< button href="https://github.com/inclusionAI/Ming-omni-tts" label="GITHUB" external=true >}} 🤗 <a href="https://huggingface.co/inclusionAI/Ming-omni-tts-0.5B">Hugging Face</a>| 🤖 <a href="https://modelscope.cn/models/inclusionAI/Ming-omni-tts-0.5B">ModelScope</a> |
There was a problem hiding this comment.
The GitHub link opens in a new tab, but the Hugging Face and ModelScope links do not. For a consistent user experience, all external links should open in a new tab. Please add target="_blank" to the other links. It's also a good security practice to add rel="noopener noreferrer" when using target="_blank".
| {{< button href="https://github.com/inclusionAI/Ming-omni-tts" label="GITHUB" external=true >}} 🤗 <a href="https://huggingface.co/inclusionAI/Ming-omni-tts-0.5B">Hugging Face</a>| 🤖 <a href="https://modelscope.cn/models/inclusionAI/Ming-omni-tts-0.5B">ModelScope</a> | |
| {{< button href="https://github.com/inclusionAI/Ming-omni-tts" label="GITHUB" external=true >}} 🤗 <a href="https://huggingface.co/inclusionAI/Ming-omni-tts-0.5B" target="_blank" rel="noopener noreferrer">Hugging Face</a>| 🤖 <a href="https://modelscope.cn/models/inclusionAI/Ming-omni-tts-0.5B" target="_blank" rel="noopener noreferrer">ModelScope</a> |
| | Instruction | TTS Result | | ||
| |---|---| | ||
| | A motor is revving and changing gears | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/yPAnRqgKG7gAAAAAgCAAAAgADvHDAQFr"></audio> | | ||
| | Thunder and a gentle rain | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/2YO-Qa73VAIAAAAAgCAAAAgADvHDAQFr"></audio> | | ||
| | Continuous snoring of a person | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/wUo6TZDgEYMAAAAAgCAAAAgADvHDAQFr"></audio> | | ||
| | Nature sounds with a frog croaking | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/ONTTTa5RbAwAAAAAgCAAAAgADvHDAQFr"></audio> | | ||
| | A man talking as a stream of water trickles in the background | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/JrsRQbkYSasAAAAAgCAAAAgADvHDAQFr"></audio> | |
There was a problem hiding this comment.
This table contains English text within a Chinese document. For consistency, the table header Instruction and its content should be translated to Chinese. The header TTS Result could also be translated.
| | Instruction | TTS Result | | |
| |---|---| | |
| | A motor is revving and changing gears | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/yPAnRqgKG7gAAAAAgCAAAAgADvHDAQFr"></audio> | | |
| | Thunder and a gentle rain | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/2YO-Qa73VAIAAAAAgCAAAAgADvHDAQFr"></audio> | | |
| | Continuous snoring of a person | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/wUo6TZDgEYMAAAAAgCAAAAgADvHDAQFr"></audio> | | |
| | Nature sounds with a frog croaking | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/ONTTTa5RbAwAAAAAgCAAAAgADvHDAQFr"></audio> | | |
| | A man talking as a stream of water trickles in the background | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/JrsRQbkYSasAAAAAgCAAAAgADvHDAQFr"></audio> | | |
| | 指令 | TTS 结果 | | |
| |---|---| | |
| | 马达转速变化和换挡声 | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/yPAnRqgKG7gAAAAAgCAAAAgADvHDAQFr"></audio> | | |
| | 雷声和细雨声 | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/2YO-Qa73VAIAAAAAgCAAAAgADvHDAQFr"></audio> | | |
| | 持续的鼾声 | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/wUo6TZDgEYMAAAAAgCAAAAgADvHDAQFr"></audio> | | |
| | 带有蛙鸣的自然声音 | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/ONTTTa5RbAwAAAAAgCAAAAgADvHDAQFr"></audio> | | |
| | 背景有水流声的男人说话声 | <audio controls src="https://mdn.alipayobjects.com/huamei_7mmngh/afts/file/JrsRQbkYSasAAAAAgCAAAAgADvHDAQFr"></audio> | |
|
alt text 的反馈其实是个有用的反馈,建议修改一轮。其他的可以跟其他 blog 统一进行修订。 |
|
感谢修订 |
No description provided.