Skip to content

Replace PR 89 with this one#97

Merged
xmulligan merged 1 commit intoinclusivenaming:mainfrom
markcmiller86:replace-pr-89
Sep 8, 2021
Merged

Replace PR 89 with this one#97
xmulligan merged 1 commit intoinclusivenaming:mainfrom
markcmiller86:replace-pr-89

Conversation

@markcmiller86
Copy link
Copy Markdown
Contributor

@markcmiller86 markcmiller86 commented Aug 12, 2021

@Oshratn and @celestehorgan

This PR should replace #89. Close #89 and work from this one instead.

  • renames file correctly to mark-miller-llnl-interview.md
  • fixes incorrect links in original
  • various minor revisions for accuracy/clarity

I originally made proposed revisions here. There is no expectation on my part that @Oshratn accept all changes here...only those addressing inaccuracies. Sorry I didn't think to separate those from a second commit for clarity. If you would prefer that, lemme know.

@markcmiller86
Copy link
Copy Markdown
Contributor Author

I am not sure what has happened with this? It seems to have been sitting here for 20+ days. I recall seeing somewhere that it was intended for Sept 8 to go live??

I am good with this now. How about others? @Oshratn @celestehorgan

@Oshratn
Copy link
Copy Markdown
Contributor

Oshratn commented Sep 5, 2021

Keeping an eye on this till the 8th and will push the button then.

@xmulligan
Copy link
Copy Markdown
Contributor

Yes, it will be published on the 8th. Thanks for your work on this 💯

@xmulligan xmulligan merged commit 43e0e81 into inclusivenaming:main Sep 8, 2021
@xmulligan
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants