Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actions/publish/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ runs:
with:
node-version: "20.16.0"
- name: Install qiita-cli
run: npm install -g @qiita/qiita-cli@v1.6.2
run: npm install -g @qiita/qiita-cli@v1.7.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

バージョン番号がハードコードされています。これにより、将来のリリースでpackage.jsonのバージョンは更新したものの、このファイルの更新を忘れてしまい、意図せず古いバージョンが使われる可能性があります。package.jsonからバージョンを動的に読み込むように変更することで、このようなヒューマンエラーを防ぎ、メンテナンス性を向上させることができます。

      run: npm install -g @qiita/qiita-cli@$(node -p "require('./package.json').version")

shell: bash
- name: Publish articles
run: qiita publish --all --root ${{ inputs.root }}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@qiita/qiita-cli",
"version": "1.6.2",
"version": "1.7.0",
"description": "Qiita CLI is a tool that allows you to write, preview and publish articles on Qiita from local environment.",
"keywords": [
"Qiita"
Expand Down