Skip to content

Conversation

@satton0894
Copy link
Contributor

@satton0894 satton0894 commented Sep 12, 2022

What

Dependabot に github-actionsの定義を追加する。

Why

Dependabotの設定を行うことで、GitHub Actionsに依存する定義を更新できるようにするため

@satton0894 satton0894 marked this pull request as draft September 13, 2022 00:47
@satton0894 satton0894 marked this pull request as ready for review September 13, 2022 02:52
@satton0894 satton0894 requested a review from mziyut September 13, 2022 03:47
Comment on lines 11 to 12
reviewers:
- "increments/shared-dev-team"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "reviewers" is need not be specified.

Suggested change
reviewers:
- "increments/shared-dev-team"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you must define "reviewers", @increments/developers is recommended.

Suggested change
reviewers:
- "increments/shared-dev-team"
reviewers:
- "increments/developers"

Copy link
Contributor Author

@satton0894 satton0894 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mziyut
Set "reviewers" to @increments/developers.
The reason is so that @increments/developers can recognize when a Dependabot is created.

@satton0894 satton0894 force-pushed the add-dependabot-definition-for-github-actions branch from 0f62f52 to 266c38e Compare September 13, 2022 04:25
@satton0894 satton0894 requested a review from mziyut September 13, 2022 04:42
Copy link
Contributor

@mziyut mziyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satton0894 satton0894 merged commit 4fe4fb8 into main Sep 13, 2022
@satton0894 satton0894 deleted the add-dependabot-definition-for-github-actions branch September 13, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants