Add incuna-pigeon to send notifications

[kevinetienne]

It looks like we have two different behaviors to send emails in django-user-management.
In some places we are sending html and text emails and in PasswordReset we only send html emails.

Using incuna-pigeon would make sending emails behaving the same accross the project and would allow apps using django-user-management to customise handlers to send emails.

As this project is compatible with django1.6 and 1.7, I think it makes sense to define the notification handlers in settings.

[meshy]

👍

[kevinetienne]

Not yet ready still need a setting to use a custom Notification

[LilyFirefly]

You use {{ protocol }} elsewhere. Is there a reason to be different here?

[kevinetienne]

Yes it should be protocol

[LilyFirefly]

You could add a Notification subclass and attach text_email_template and html_email_template as class attributes. In projects we've then added the Notification subclass to an AppConfig to allow overriding/extension.

[coveralls]

Coverage remained the same at 100.0% when pulling 280d595 on use-incuna-pigeon into be3ca0a on master.

[coveralls]

Coverage remained the same at 100.0% when pulling e2387e6 on use-incuna-pigeon into be3ca0a on master.

[kevinetienne]

Updated

[meshy]

First line of multiline docstrings on new line, please.

[kevinetienne]

Updated

[LilyFirefly]

'my_custom_email.txt'

[LilyFirefly]

I would do from user_management.utils import notifications and then notifications.PasswordResetNotification later.

[coveralls]

Coverage remained the same at 100.0% when pulling ca69ca8 on use-incuna-pigeon into be3ca0a on master.

[LilyFirefly]

Instead of mocking the notification, you could mock the user I think. You don't care how uid or token are calculated for this test.

[meshy]

Both notification and user are very silly.

[LilyFirefly]

Huh? Can you explain what you mean?

[meshy]

Instead of mocking the notification, you could mock the user I think.

user are a stupid-head. :P

[meshy]

[LilyFirefly]

😒

[kevinetienne]

Makes sense I think, the link (uid and token) is already asserted when rendering the template, probably best to make an assertCountEqual.

[kevinetienne]

Don't merge yet I've spotted an error in the templates

[kevinetienne]

Templates have been updated

[coveralls]

Coverage remained the same at 100.0% when pulling 0c6ff45 on use-incuna-pigeon into 6e4d651 on master.