Add default throttle rates for login and password #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@meshy How about |
Contributor
|
Seems ok -- maybe 2 is a little restrictive, though. 3-4, perhaps? |
Author
|
I can't think of a reason to request more than one password reset, but 3 doesn't seem unreasonable. |
* Limit GetToken requests to 10/hour * Limit PasswordResetEmail requests to 3/hour
Author
|
@meshy Review? |
meshy
added a commit
that referenced
this pull request
Jun 20, 2014
Add default throttle rates for login and password
Contributor
|
Thanks, coveralls. Great timing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should add sane defaults so these views are protected by default.