Allow more customisation of account verification email #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 20, 2014 11:34
* Use plain text email by default
* Set EMAIL_SUBJECT_TEMPLATE on VerifyEmailMixin * Refactor send_validation_email to allow easier testing
* Add _get_email_context helper method * Simplify _get_email_kwargs method
* Avoid duplicating work in test__email_context and test__get_email_kwargs
* Allow the email templates used by send_validation_email to be overriden or disabled. * Allow the context provided to the email templates to be extended. * Add a docstring to send_validation_email.
Author
|
@adam-incuna @meshy Review? |
user_management/models/mixins.py
Outdated
Contributor
There was a problem hiding this comment.
The underscore suggests that this should not be lightly overridden. Is that the case?
* Make email_kwargs part of the public api * Standardise naming to match email_context
Author
|
@adam-incuna @meshy Updated. |
user_management/models/mixins.py
Outdated
Author
There was a problem hiding this comment.
Maybe template isn't the best word - I'm not referring to a django template here. EMAIL_SUBJECT_TEMPLATE is a string that is used with .format in get_email_subject.
Contributor
There was a problem hiding this comment.
Oh cool :) maybe specify that?
Contributor
|
Nice one, this looks like a really useful improvement! |
Contributor
|
👍 happy to merge if @meshy is! |
user_management/models/mixins.py
Outdated
Contributor
|
Looks good other than my comment about the return statement. |
adam-thomas
added a commit
that referenced
this pull request
Aug 20, 2014
Allow more customisation of account verification email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
VerifyEmailMixin.send_validation_emailwe hard-code the email subject. We also assume only a html email is sent.