ProfileAvatar doesn't specify permissions #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Contributor
|
👍 |
Added tests
Contributor
|
Review Please? Yes I'm aware of the typo in the branch name. |
There was a problem hiding this comment.
Why are you setting request.user for an unauthenticated request?
user_management/api/avatar/views.py
Outdated
There was a problem hiding this comment.
I don't think IsAuthenticatedOrReadOnly is necessary.
Contributor
Author
There was a problem hiding this comment.
The avatar will need to be gotten by unauthenticated users, so I think IsAuthenticatedOrReadOnly is correct.
There was a problem hiding this comment.
That's what the UserAvatar view is for I think.
There was a problem hiding this comment.
You don't care about this user any more.
There was a problem hiding this comment.
You're not actually testing post here.
Contributor
|
@ian-foote That should do it |
1 similar comment
LilyFirefly
pushed a commit
that referenced
this pull request
Oct 28, 2014
ProfileAvatar doesn't specify permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProfileAvatardoesn't setpermission_classes. This should useIsAuthenticatedto avoid the possibility of misconfiguration.