Avatar compatibility improvements #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds (for avatars only): - Token Authentication as a form variable. - POST for update (with disabled CSRF).
meshy
force-pushed
the
avatar-improvements
branch
from
8fa7965 to
d23e7c5
Compare
meshy
force-pushed
the
avatar-improvements
branch
from
d23e7c5 to
d8425e3
Compare
Contributor
Author
|
@kevinetienne @adam-incuna please review |
Contributor
Author
There was a problem hiding this comment.
I think this variable is misnamed
There was a problem hiding this comment.
Just thinking of yesterday's rabbit hole.
Contributor
There was a problem hiding this comment.
We can maybe have a base class or a mixin to avoid some duplication with the two classes ProfileAvatar and UserAvatar?
Contributor
Author
|
Updated |
kevinetienne
pushed a commit
that referenced
this pull request
Nov 18, 2014
Avatar compatibility improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.