fix(go): resolve memory leak, O(n^2) drain, and API improvements#13
Merged
fix(go): resolve memory leak, O(n^2) drain, and API improvements#13
Conversation
- Zero front slot in Dequeue to prevent memory leak
- Replace O(n²) GetMessagesAndDequeue with O(1) DrainAll
- Remove fmt.Println from library code
- Add nil queue guard with lazy init in Toaster.Queue()
- Add ErrEmptyQueue sentinel error
- Fix error wrapping: %v → %w in gohtml.go
- Fix incorrect godoc ("returns -1" → "returns zero-value Toast")
- Remove dead Icon type
- Return shallow copy from Builder.Build() to prevent shared state
- Fix test bug in options_test.go expected values
- Add missing tests for NewToast
- Add godoc to exported symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetMessagesAndDequeuewith O(1)DrainAllfmt.Printlnfrom library codeErrEmptyQueuesentinel, and godocBuilder.Build()to prevent shared stateIcontype, fix error wrapping (%v->%w)