refactor(cli/install): split entry into submodules#155
Merged
Conversation
Move argv, GHCR URL, DB record, download, post_install, and local formula helpers into src/cli/install/ submodules. install.zig becomes an 887-LOC orchestrator that re-exports the public API so external callers keep working unchanged. Binary size unchanged; drops unused install_mod import from doctor.zig.
indaco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split
src/cli/install.ziginto six submodules undersrc/cli/install/(args,ghcr_url,record,download,post_install,local) plus an entry orchestrator. Every function body moved verbatim;install.zignow re-exports the public API so external callers (core/bottle,core/cask,update/verify,cli/bundle,cli/restore,main,lib) and all existing tests keep working unchanged.Related Issue
Notes for Reviewers