refactor: unify post_install routing between install and migrate#156
Merged
refactor: unify post_install routing between install and migrate#156
Conversation
Both commands now drive post_install through a single shared helper, so human and JSON envelopes match byte-for-byte regardless of which command ran the hook. Migrate's duplicated decision tree is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate now calls the shared
post_install.drivehelper instead of carrying its own copy of the locate -> execute -> route -> fall back decision tree. Both commands route through one entry point, so users see byte-identical human and JSON envelopes for every post_install outcome regardless of which command did the work.Related Issue
Notes for Reviewers