fix(cli/bundle): honor global --dry-run in bundle install#159
Merged
Conversation
main.zig strips --dry-run from argv, so cmdInstall's local arm never fired and the runner ran non-dry: it recorded a bundles row on every `mt bundle install --dry-run`. Read output.isDryRun() instead, matching every other subcommand, so the dry-run envelope is actually dry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mt bundle install --dry-runwas silently invoking the real dispatcher and writing abundlesrow to the DB.main.zigconsumes the global--dry-runbefore it reachescmdInstall, so the local arm never fired and the runner ran non-dry. Readingoutput.isDryRun()instead (the single source every other subcommand already uses) makes the dry-run envelope actually dry: the dispatcher stays quiet, and the DB is untouched.Related Issue
Notes for Reviewers