refactor(ui): route stdin probes and prompt reads through pkg_io#288
Merged
refactor(ui): route stdin probes and prompt reads through pkg_io#288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns the two remaining stdin reads in
src/ui/with the seededpkg_iosoAppCtx.ioredirection observes them like every other I/O in the module:confirmTypednow reads viastd.Io.File.readStreaming(pkg_io, ...), matching theisTtyprobe it already routes throughpkg_io. Behind a small extracted helper so unit tests can drive the read against a pipe instead of needing a real TTY.ui/colorreads its response the same way, removing the laststd.posix.read(stdin)bypass in the UI layer.Also pins the
quiet/verbose/debug/dry_run/mode/ndjsonmutation contract in a comment: these flags are configured by argv parsing before any worker thread spawns, so plain reads/writes stay race-free; future runtime mutators must migrate the flag and its readers to@atomicLoad/@atomicStore(matchingpost_install_emitnext door). Promoting them eagerly cost ~3 KB of code that crossed a Mach-O page boundary into a 16 KB on-disk hit for a race no caller actually produces - a real binary-size regression for a theoretical concern.Related Issue
Notes for Reviewers