Conversation
Hoist the cask lookup out of both per-entry loops so a real prepare failure routes through the loud err_kind path instead of silently emptying the candidate set, and self-heal a missing schema via initSchema to match runStoreOrphans / runUnusedDeps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A consistent SQLite prepare failure inside
purge --stale-casks(schema drift, lock held, partially corrupted DB) used to empty the candidate set silently - the JSON wire output then read identically to a clean "no stale casks" run. This restores the loud-error contract that--store-orphansand--unused-depsalready follow:status = "err"witherror_kind = "db_prepare"and writes a stderr line, so JSON consumers can distinguish "nothing to do" from "every probe failed".initSchema, matching the sibling scopes, so a freshly-installed prefix is no longer reported as a fault.Related Issue
Notes for Reviewers