Conversation
…modes Operators triaging a post_install failure now see one of TapNotFound, FetchFailed, or PostInstallBodyNotFound depending on which arm fired, instead of every miss collapsing onto TapNotFound. A hash mismatch is no longer filed as "no local tap".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pre-fix, every post_install source-resolution miss surfaced as
RubyError.TapNotFoundregardless of which arm actually failed, sending operators down the wrong triage path - notably a hash mismatch on the GitHub fallback was reported identically to "no local tap clone".The resolver now returns the deepest-known reason:
TapNotFoundwhen no local homebrew-core tap is on disk,FetchFailedwhen the hash-pinned GitHub fallback failed (network, HTTP, hash mismatch, or formula absent from the pinned manifest), andPostInstallBodyNotFoundwhen source was retrieved but no parseabledef post_installbody could be extracted. Each variant carries a distinct describeError string so the warning the operator sees points at the actual cause.Related Issue
Notes for Reviewers