fix(clix): eliminate data race in test-race CI job (#238)

* fix(clix): eliminate data race on global defaultManager in tests

* chore(justfile): use test-race on to install recipe

Author: indaco

internal/clix/clix.go

@@ -27,14 +27,20 @@ func FromCommand(cmd *cli.Command) (bool, error) {
 // It returns true if the file was created, false if it already existed.
 // Returns a typed error (*apperrors.VersionFileNotFoundError) instead of cli.Exit.
 func GetOrInitVersionFile(path string, strict bool) (bool, error) {
+	return getOrInitVersionFileWith(path, strict, semver.DefaultVersionManager())
+}
+
+// getOrInitVersionFileWith is the internal implementation that accepts a
+// VersionManager, avoiding reliance on package-level mutable state.
+func getOrInitVersionFileWith(path string, strict bool, mgr *semver.VersionManager) (bool, error) {
 	if strict {
 		if _, err := os.Stat(path); err != nil {
 			return false, &apperrors.VersionFileNotFoundError{Path: path}
 		}
 		return false, nil
 	}
 
-	created, err := semver.InitializeVersionFileWithFeedback(path)
+	created, err := mgr.InitializeWithFeedback(context.Background(), path)
 	if err != nil {
 		return false, err
 	}

internal/clix/clix_test.go

@@ -64,20 +64,19 @@ func TestGetOrInitVersionFile(t *testing.T) {
 }
 
 func TestGetOrInitVersionFile_InitError(t *testing.T) {
-	t.Parallel(
-	// Use MockFileSystem with write error to simulate initialization failure
-	)
+	t.Parallel()
 
+	// Use MockFileSystem with write error to simulate initialization failure.
+	// Call getOrInitVersionFileWith directly with the mock manager to avoid
+	// mutating the package-level global defaultManager.
 	mockFS := core.NewMockFileSystem()
 	mockFS.WriteErr = errors.New("mock init failure")
 
 	mgr := semver.NewVersionManager(mockFS, nil)
-	restore := semver.SetDefaultManager(mgr)
-	defer restore()
 
 	targetPath := "/test/.version"
 
-	created, err := GetOrInitVersionFile(targetPath, false)
+	created, err := getOrInitVersionFileWith(targetPath, false, mgr)
 	if err == nil {
 		t.Fatal("expected error, got nil")
 	}

justfile

@@ -43,7 +43,7 @@ build:
     @ls -lh {{ build_dir }}/{{ app_name }} | awk '{print "  " $5}'
 
 # Install the binary using Go install
-install: check test-force
+install: check test-race
     @. {{ logger }} && log_info "Install the binary using Go install"
     cd {{ cmd_dir }} && {{ go }} install {{ buildflags }} -ldflags="{{ ldflags }}" .