fix(clix): eliminate data race in test-race CI job#238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix intermittent
test-raceCI failures caused by a data race ininternal/clixtests.TestGetOrInitVersionFile_InitErrormutated the package-leveldefaultManagerviasemver.SetDefaultManager()while parallel tests read it throughsemver.InitializeVersionFileWithFeedback().Refactored
GetOrInitVersionFileto delegate to an internalgetOrInitVersionFileWiththat accepts a*semver.VersionManager, so tests inject mocks directly without touching global state.Also use
test-raceas a dependency of theinstalljustfile recipe so race conditions are caught locally.Related Issue
Notes for Reviewers