fix(tag): add multi-module workspace support#209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where
sley tag create,sley tag push, andsley tag listcommands fail in multi-module projects with the erroropen .version: no such file or directory.Changes Made
--all,--module,--modules,--pattern) to thetagcommand viacliflags.MultiModuleFlags()resolveVersionPath()function that usesclix.GetExecutionContextto properly detect and handle multi-module workspacesrunCreateCmdandrunPushCmdto callresolveVersionPath()instead ofgetVersionPath()--all/--moduleflags, users are prompted to select which module's version to tagBehavior
Single-module projects: Works exactly as before (backward compatible)
Multi-module projects:
--allflag: Auto-selects first module (no prompt)--module <name>flag: Uses specified module's versionRelated Issue
Fixes #208
Notes for Reviewers