fix(tagmanager): commit modified files before creating tag#214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix tag-manager
auto-createto commit all bump-modified files before creating the git tag, ensuring the tag points to the correct release commit.Previously, when
auto-create: truewas set, the tag was created immediately after the version bump without committing the modified files first. This meant the tag pointed to the commit before the release changes (.versionfile, changelog, dependency files, etc.).Now the flow is: bump -> post-bump actions -> commit all modified files -> create tag on the release commit.
Also adds a new optional
commit-message-templateconfig (default:"chore(release): {tag}") to customize the commit message.Related Issue
Fixes #213
Notes for Reviewers
auto-create: truenow inherently includes the commit step — no separate opt-in neededGitCommitOperationsinterface follows the same DI pattern as the existingGitTagOperations