Skip to content

refactor(core): add context to git interfaces and remove type assertions#226

Merged
indaco merged 1 commit intomainfrom
fix/interfaces-and-context
Mar 9, 2026
Merged

refactor(core): add context to git interfaces and remove type assertions#226
indaco merged 1 commit intomainfrom
fix/interfaces-and-context

Conversation

@indaco
Copy link
Copy Markdown
Owner

@indaco indaco commented Mar 9, 2026

Description

  • Add context.Context as the first parameter to all GitTagOperations and GitCommitOperations in core/interfaces.go
  • Update all implementations in tagmanager/git.go to use exec.CommandContext for cancellable subprocess execution
  • Promote IsEnabled(), IsAutoCreateEnabled(), GetConfig(), CommitChanges() onto plugin interfaces (TagManager, VersionValidator, ReleaseGate)
  • Eliminate all type assertions in commands/bump/helpers.go and commands/depsync/sync.go
  • Update all mocks (core/mocks.go, tagmanager mock files) to match new signatures

Related Issue

Notes for Reviewers

@indaco indaco merged commit da7fe29 into main Mar 9, 2026
7 checks passed
@indaco indaco deleted the fix/interfaces-and-context branch March 9, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant