refactor(bump): delegate single-module bumps to operations.BumpOperation#227
Merged
refactor(bump): delegate single-module bumps to operations.BumpOperation#227
Conversation
Unify version bump logic so single-module and multi-module paths share the same BumpOperation implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unify the dual bump logic paths. Single-module bumps now delegate to
operations.BumpOperationinstead of maintaining separate version incommands/bump/common.go.This removes the
versionCalculatortype,makePatchCalculator/makeMinorCalculator/makeMajorCalculator, and duplicateextractPreReleaseBase, consolidating all bump logic through the operations package.Related Issue
Notes for Reviewers
BumpResultstruct withPreview()andWrite()added tooperations.BumpOperationExtractPreReleaseBaseexported fromsemver/manager.goas the canonical locationpre.goandrelease.gosimplified by delegating to the unified path