refactor(plugins): remove per-package registry singletons and legacy function variables#228
Merged
refactor(plugins): remove per-package registry singletons and legacy function variables#228
Conversation
…global func vars Replace mutable var XxxFn globals with direct function calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove legacy global state from the plugin system and command infrastructure. This eliminates per-package
registry.gosingleton files (dead code superseded by the centralizedPluginRegistry) and migrates mutablevar XxxFnfunction variables to plain exported functions, improving testability and removing race condition risks.Related Issue
Notes for Reviewers
tagmanager,commitparser,versionvalidator,releasegate,dependencycheck,auditlog,changeloggenerator,changelogparser- none were called from production codeFromConfigStruct()moved fromauditlog/registry.gotoauditlog/config.go(only production-used symbol from deleted files)RunPreReleaseHooksFn->RunPreReleaseHooksFromCommandFn->FromCommandLoadConfigFn->LoadConfigSaveConfigFn->SaveConfigLoadPreReleaseHooksFromConfigFn->LoadPreReleaseHooksFromConfigPluginRegistrydirectly instead of overriding per-packageGetXxxFnglobals