Skip to content

refactor: move SyncDependencies to operations, fix hooks and code quality#232

Merged
indaco merged 4 commits intomainfrom
refactor/architecture-quality
Mar 11, 2026
Merged

refactor: move SyncDependencies to operations, fix hooks and code quality#232
indaco merged 4 commits intomainfrom
refactor/architecture-quality

Conversation

@indaco
Copy link
Copy Markdown
Owner

@indaco indaco commented Mar 11, 2026

Description

Architecture and code quality improvements:

  • Move SyncDependencies and DeriveDependencyName from commands/depsync to internal/operations to break circular dependency between command packages
  • Create fresh hook runner per RunPreReleaseHooks call instead of using a package-level default, ensuring the current hook list is always used
  • Remove blank line between doc comment and CommitParser interface declaration
  • Replace fmt.Errorf with typed apperrors.InvalidBumpTypeError in BumpByLabel

The commands/depsync package is kept as a thin delegation wrapper for backward compatibility.

Related Issue

  • None

Notes for Reviewers

The commands/depsync package now only delegates to operations.SyncDependencies. Existing callers outside the bump command continue to work unchanged.

@indaco indaco merged commit 742e26e into main Mar 11, 2026
7 checks passed
@indaco indaco deleted the refactor/architecture-quality branch March 11, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant