fix(tests): use mock git ops to prevent tag leaks from bump auto tests#233
Merged
fix(tests): use mock git ops to prevent tag leaks from bump auto tests#233
Conversation
All NewTagManager() calls in bump tests replaced with NewTagManagerWithOps() using MockGitTagOperations and MockGitCommitOperations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All
tagmanager.NewTagManager()calls in bump test files replaced withtagmanager.NewTagManagerWithOps()usingMockGitTagOperationsandMockGitCommitOperations. Two call sites withEnabled: true, AutoCreate: truewere actively creating realv99.88.77andv1.2.4tags in the working repository on every test run. The remaining four call sites (currentlyEnabled: false) were also updated for defensive consistency - a future edit flipping the flag would silently reintroduce the leak.Related Issue
Notes for Reviewers