test: improve test parallelism, deterministic sync, and DI refactoring#234
Merged
test: improve test parallelism, deterministic sync, and DI refactoring#234
Conversation
SetTheme()/resetTheme() mutate package-level var currentTheme, causing race conditions when subtests run in parallel under -race.
Each parallel subtest now uses its own t.TempDir() instead of sharing a single script path that races between write and exec.
Add ManifestLoader field to ExtensionHookRunner struct, replacing direct calls to the extensions.LoadExtensionManifestFn global. RunHooks() and LoadExtensionsForHook() now use the injected loader, enabling safe t.Parallel() under -race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve test suite quality
Related Issue
Notes for Reviewers
changelogparserandversionvalidatorwherevar openFileFn/var getCurrentBranchFnglobals were moved into struct fields - behavior is identicalcommands/bump,config,core) hadt.Parallel()intentionally removed until they get the same DI refactoringManifestLoaderfield toExtensionHookRunnerstruct, replacing direct calls to theextensions.LoadExtensionManifestFnglobal.RunHooks()andLoadExtensionsForHook()now use the injected loader, enabling safet.Parallel()under-race.