refactor: eliminate shared mutable state via struct-based DI#235
Merged
refactor: eliminate shared mutable state via struct-based DI#235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace package-level function variables with struct-based dependency injection across packages. This eliminates shared mutable state and made dependency flow implicit.
Changes by package:
GitOpsstruct encapsulates git function fields;IsInteractiveFn/ConfirmMergeFnmoved to plugin struct fieldsDependencyCheckerPluginstruct fields, initialized in constructorGitLogstruct withExecCommandFnfield;GetCommitsFntype andDefaultGetCommitsFn()factory for callersnowFuncglobal replaced with optionalNowFuncparameter onNewTemplateData()bumpDepsstruct with context-based injection viacontext.WithValue; holds inference, bumper, and commit retrieval functionsLoadExtensionManifestFnglobal var replaced with exportedLoadExtensionManifest()function; all callers updatedcopyDirFnanddefaultFileCopierglobal vars; tests useNewOSFileCopier()orMockFileCopierdirectlyos.Getwd/os.Chdir/os.Unsetenvwitht.Chdir()andt.Setenv()for proper test isolationRelated Issue
Notes for Reviewers
readFileFn/writeFileFnindependencycheck/parsers.goremain as package-level vars (adapter-level, not plugin-level)