fix(plugins): handle repos with fewer than 10 commits in bump auto#236
Merged
fix(plugins): handle repos with fewer than 10 commits in bump auto#236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
sley bump autoin a repo with no tags and fewer than 10 commits, both the commit-parser and changelog-generator plugins fell back toHEAD~10, which is an invalid ref in shallow repos. This causedgit logto fail with "unknown revision."This PR extracts a shared
git.SafeFallbackSincehelper ininternal/git/ref.gothat counts available commits and falls back to the root commit hash when the repo has fewer thanncommits. Bothgitlog.GitLogandchangeloggenerator.GitOpsnow use it instead of hardcodingHEAD~10.Related Issue
Notes for Reviewers