fix: per-module tag config loading and {module_path} template variable#242
Merged
fix: per-module tag config loading and {module_path} template variable#242
{module_path} template variable#242Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
sley tag --moduleto load and merge per-module.sley.yamlconfig, and add{module_path}template variable support intag-manager.prefixfor Go monorepo compatibility.Both tag and bump flows are covered. The config validator bypasses the
/char rejection for template prefixes and warns when{module_path}is used without workspace discovery enabled.Related Issue
tag --moduledoes not pick up per-module.sley.yamltag-manager config #240{module_path}placeholder intag-manager.prefixfor Go monorepo tags #241Notes for Reviewers
InterpolatePrefixlives intagmanager/template.go(nottagcmd.go) so both tag and bump commands can import it.os.Getwd()is used for relative path computation sinceresolveVersionPathreturns absolute paths fromworkspace.Module.Path.