fix: tag create --all iterates all modules with per-module prefix#251
Merged
fix: tag create --all iterates all modules with per-module prefix#251
Conversation
… resolution Previously tag create --all only processed the first module (modules[0]). Now it iterates all discovered modules, resolves per-module tag prefix via config merge, skips duplicate tags with info message, and continues on individual module failure with a summary error.
Add TestCreateTagsForAllModules with 4 subtests (all succeed, missing version file, duplicate tag skipped, creation failure continues) and TestResolveModuleConfig with 2 subtests.
The test expected single-module output (Using version from module) but now --all iterates all modules. Updated assertions to match new behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sley tag create --allpreviously only processed the first module (modules[0]) instead of iterating all discovered modules. This PR fixes that by adding acreateTagsForAllModulesfunction that:LoadConfigFromDir+MergePluginConfig)Related Issue
Follow-up to #240 / #241 (module-path tag prefix)
Notes for Reviewers