fix: suppress version mismatch warnings in independent versioning mode#252
Merged
fix: suppress version mismatch warnings in independent versioning mode#252
Conversation
Add workspace.versioning field (independent|coordinated) to WorkspaceConfig. When set to independent, discover command shows mismatches as info summaries instead of warnings. Updates text, table, and JSON output formatters. JSON output gains a versioning_mode field for machine consumers.
Add TestWorkspaceConfig_IsIndependentVersioning, TestWorkspaceConfig_VersioningMode, TestLoadConfig_InvalidVersioning for config validation. Add versioning mode tests for JSON, text, table formatters and workflow mismatch handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a workspace uses independent versioning (each module at its own version),
sley discoverincorrectly reported version differences as warnings. This PR adds aworkspace.versioningconfig field and adjusts the discover command output:versioningfield toWorkspaceConfig(valid values:independent,coordinated, or empty/default)IsIndependentVersioning()andVersioningMode()helper methodsindependentmode: mismatches shown as info summaries ("version differences are expected")coordinatedmode (default): existing warning behavior preservedversioning_modefield for machine consumersRelated Issue
Notes for Reviewers
versioningfield default tocoordinated(unchanged behavior)