feat: extend config merge with non-plugin field semantics#254
Merged
Conversation
…ions, hooks) Rename MergePluginConfig to MergeConfig (deprecated alias preserved). Theme: module wins if set. Extensions: additive merge deduplicated by name. PreReleaseHooks: additive merge (root first, then module). All slice fields are deep-copied to prevent mutation of root config.
Add TestMergeConfig_Theme, TestMergeConfig_Extensions_Additive, TestMergeConfig_PreReleaseHooks_Additive, TestMergeConfig_DeepCopy, TestMergeConfig_PathAlwaysRoot, TestMergeConfig_WorkspaceAlwaysRoot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MergePluginConfigpreviously only merged plugin pointer fields, copying all non-plugin fields (Theme,Extensions,PreReleaseHooks) directly from root. This PR renames it toMergeConfigand adds field-by-field merge semantics:PathWorkspaceThemeExtensionsName(module wins on conflict)PreReleaseHooksRelated Issue
Notes for Reviewers
MergePluginConfigalias is preserved for backward compatibility. Both existing call sites (helpers.go,tagcmd.go) updated to useMergeConfig.