fix: add multi-module flags to tag subcommands#259
Merged
Conversation
Move MultiModuleFlags to create, list, and push subcommands. Remove -m alias from --message on create to avoid conflict with --module alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Multi-module flags (
--module,--all,--pattern, etc.) were defined only on the parenttagcommand. Due to theBeforehook on the parent, urfave/cli/v3 did not propagate these flags to subcommands - runningsley tag create --module <name>failed with "flag provided but not defined".This moves
MultiModuleFlags()to each subcommand that supports multi-module operations (create,list,push), matching how thebumpcommand handles flag inheritance.Also removes the
-malias from--messageontag createto avoid conflict with--module's-malias fromMultiModuleFlags.Related Issue
Notes for Reviewers