Subscriptions refactor #222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpigsley
reviewed
Jun 24, 2017
| @@ -0,0 +1,145 @@ | |||
| class SubscriptionService < Service | |||
Contributor
There was a problem hiding this comment.
Controllers to Services! Love it!
|
|
||
| def self.transition_plan user:, old_plan:, new_plan:, stripe_object: nil | ||
| # Fetch the user's current Stripe information | ||
| stripe_object ||= SubscriptionService.stripe_customer_object_for(current_user) |
Contributor
There was a problem hiding this comment.
Any chance this could still return nil?
| ) | ||
|
|
||
| report_subscription_change_to_slack current_user, old_billing_plan, new_billing_plan | ||
| SubscriptionService.report_subscription_change_to_slack current_user, old_billing_plan, new_billing_plan |
Contributor
There was a problem hiding this comment.
Ooo didn't realize this was a thing!
houndci-bot
reviewed
Sep 30, 2017
| add_referral_benefits_to( | ||
| referree: user | ||
| referrer: user.referrer || user # if a user wasn't referred by anyone, we treat them as referring themselves <3 | ||
| ) |
| add_first_time_premium_benefits_to(user) | ||
| add_referral_benefits_to( | ||
| referree: user | ||
| referrer: user.referrer || user # if a user wasn't referred by anyone, we treat them as referring themselves <3 |
| SubscriptionService.add_referral_benefits_to( | ||
| referree: current_user | ||
| referrer: current_user.referrer || current_user | ||
| ) |
| SubscriptionService.add_first_time_premium_benefits_to(current_user) | ||
| SubscriptionService.add_referral_benefits_to( | ||
| referree: current_user | ||
| referrer: current_user.referrer || current_user |
| success = SubscriptionService.transition_plan( | ||
| user: current_user, | ||
| old_plan: BillingPlan.find(current_user.selected_billing_plan_id) | ||
| new_plan: BillingPlan.find(new_plan_id), |
There was a problem hiding this comment.
unexpected token tIDENTIFIER
unexpected token tCOMMA
Member
Author
|
Replaced by #263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, not ready to merge and needs tested