refactor(config): remove redundant DEV_URL and PROD_URL#34
Merged
gustavovalverde merged 3 commits intomainfrom May 28, 2025
Merged
refactor(config): remove redundant DEV_URL and PROD_URL#34gustavovalverde merged 3 commits intomainfrom
gustavovalverde merged 3 commits intomainfrom
Conversation
…L fields - Remove DEV_URL and PROD_URL fields from AzulSettings class - Remove unnecessary field validator for empty URL strings - Remove unused imports (field_validator, AzulEndpoints) - Update unit tests to remove references to deleted fields - Fix test_process_3ds_method to properly set up session data The DEV_URL and PROD_URL fields were redundant because: - AzulAPI client uses AzulEndpoints.get_url() directly from constants - No business case for overriding standard Azul URLs via environment - ALT_PROD_URL and ALT_PROD_URL_PAYMENT remain for legitimate overrides BREAKING CHANGE: DEV_URL and PROD_URL environment variables are no longer supported"
- Replace broad exception catching with specific exceptions in config.py - Add get_api_url() method to AzulSettings to satisfy min public methods requirement - Fix redefined outer name warnings in test files by renaming parameters - Resolve protected access warnings by improving mock configuration - Add missing AzulEndpoints import and fix method references - Create fixture aliases in test_secure_service_unit.py to avoid naming conflicts - Update mock setup in conftest.py to properly handle private method mocking Fixes pylint warnings: W0718, R0903, W0621, W0212, W0613 All unit tests passing (35/35) with no remaining linter errors."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DEV_URL and PROD_URL fields were redundant because:
BREAKING CHANGE: DEV_URL and PROD_URL environment variables are no longer supported"