Skip suppliers on terminal cancel regardless of result#423
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the broker workflow so that when a requester sends a “terminal” cancel addressed to the broker symbol, remaining new suppliers are skipped immediately (rather than waiting for a supplier cancel response), while still forwarding supplier cancel responses appropriately.
Changes:
- Move “skip new suppliers on broker-symbol cancel” behavior into
RequesterMessageReceivedvia a newterminalCancel(...)helper. - Rename
handleAndCheckCancelResponsetoshouldForwardSAMand adjust logic so broker-symbol cancel responses are forwarded without re-skipping suppliers. - Update and extend workflow tests to cover the new terminal-cancel behavior and the renamed helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| broker/service/workflow.go | Implements terminal-cancel detection and skips new suppliers on broker-symbol cancel; renames cancel-response forwarding helper. |
| broker/service/workflow_test.go | Updates existing tests for renamed helper and adds coverage for broker vs supplier cancel behavior in RequesterMessageReceived. |
Comments suppressed due to low confidence (1)
broker/service/workflow.go:154
- Log message contains a duplicated word ("failed to to find...") which looks like a typo and makes log searching harder. Update the message to remove the extra "to".
lastEvent, err := w.eventBus.GetLatestRequestEventByAction(ctx, illTransId, string(iso18626.TypeActionCancel))
if err != nil {
ctx.Logger().Error("failed to to find last event with action cancel", "error", err)
return true
JanisSaldabols
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.