CROSSLINK-250 multiple symbols per tenant#526
Merged
adamdickmeiss merged 28 commits intomainfrom Apr 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a centralized symbol-resolution/validation component (api.SymbolChecker) to support tenant-derived symbols (and branch symbols) across API handlers and the SSE broker, aligning with the goal of allowing multiple symbols per tenant.
Changes:
- Added
api.SymbolChecker(with tests) and updated API/SSE handlers to use it for resolving symbols fromX-Okapi-Tenantand/orsymbol. - Updated wiring in
app.goto construct and pass a configuredSymbolChecker(with illRepo + directory adapter) into handlers. - Adjusted/expanded API tests and SSE tests to reflect updated request validation behavior.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| broker/api/symbol_checker.go | New symbol/tenant resolution + branch symbol validation logic. |
| broker/api/symbol_checker_test.go | Unit tests for SymbolChecker, including repo-backed validation cases. |
| broker/api/api-handler.go | Uses SymbolChecker for ownership and tenant-based filtering; begins multi-symbol support. |
| broker/patron_request/api/api-handler.go | Replaces direct symbol resolution with SymbolChecker in patron request endpoints. |
| broker/api/sse_broker.go | SSE endpoint now resolves symbol via SymbolChecker and adjusts validation errors. |
| broker/app/app.go | Wires SymbolChecker into API handler, patron request handler, and SSE broker; adds /broker/sse/events route. |
| broker/api/common.go | Removes the old GetSymbolForRequest helper. |
| broker/api/common_test.go | Removes tests for the deleted GetSymbolForRequest. |
| broker/test/api/api-handler_test.go | Updates test handler construction to pass a SymbolChecker. |
| broker/patron_request/api/api-handler_test.go | Updates patron request handler tests to pass a SymbolChecker. |
| broker/test/api/sse_broker_test.go | Updates SSE error expectations and adds a “missing tenant” test for broker-prefixed SSE. |
jakub-id
reviewed
Apr 15, 2026
jakub-id
reviewed
Apr 15, 2026
…e-symbols-per-tenant
jakub-id
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://index-data.atlassian.net/browse/CROSSLINK-250