Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts broker API pagination metadata so the last link is omitted when the current page is already the last page, reducing redundant navigation links in list responses.
Changes:
- Update
CollectAboutDatato only populateLastLinkwhenoffset < lastOffset. - Add unit test coverage validating
PrevLink/NextLink/LastLinkbehavior across pages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| broker/api/common.go | Prevents emitting LastLink when already on the last page (offset == lastOffset). |
| broker/api/common_test.go | Adds pagination link tests to verify the updated LastLink behavior and related links. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.