Skip to content

Conversation

@mtasaka
Copy link
Contributor

@mtasaka mtasaka commented Nov 21, 2023

glibc 2.39 does some refactoring for header file inclusion and some additional header inclusion is needed for yaz source.

Closes #104 .

glibc 2.39 does some refactoring for header file inclusion
and some additional header inclusion is needed for yaz
source.

Closes indexdata#104 .
@atsampson
Copy link

In case anyone runs into it, adding these missing #includes fixes test suite failures in test_retrieval and test_record_conv with glibc 2.39 (it's because getenv was being used with an incorrect implicit prototype).

@ryandesign
Copy link

Not only glibc is affected. I observed the problem on macOS 12; macOS does not use glibc.

It's the general principle include what you use.

@jakub-id
Copy link
Contributor

jakub-id commented Jun 5, 2024

Tested on macOS Sonoma 14.5 with libxml2 2.9.13 (apple) and libxml2 2.12.7 (brew). The problem shows with libxml2 2.12.7 so this is not related to the glibc version but libxml2's. I can't, however, reproduce #103

@jakub-id jakub-id self-requested a review June 5, 2024 19:45
@jakub-id jakub-id self-assigned this Jun 5, 2024
@jakub-id jakub-id merged commit 5dfb562 into indexdata:master Jun 5, 2024
@jakub-id jakub-id changed the title FIX: fix build error with glibc 2.39 FIX: fix build error with libxml2 2.12 Jun 14, 2024
@jakub-id
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

build error for yaz 5.34.0 with glibc 2.38.9000

4 participants