updates to pass aws configs to merge and support s3#5
Merged
Conversation
schenksj
added a commit
that referenced
this pull request
Mar 23, 2026
…t assertions Review issue #1 (panic! in production): All panic! calls confirmed to be in #[cfg(test)] blocks only. Improved messages with {:?} formatting for better debugging (e.g., "expected Add, got {:?}"). Review issue #2+4 (cache race condition + unwrap): Replaced peek()+unwrap() pattern in TimedLruCache::get() with direct get() that atomically checks existence and promotes in LRU order. No unwrap() remaining in the code path. Note: the original code was technically safe (write lock held), but the new pattern is clearer and eliminates the unwrap entirely. Review issue #3 (credential exposure): Verified all debug_println! calls log only storage paths and version numbers — never credentials. The macro is no-op unless TANTIVY4JAVA_DEBUG=1 environment variable is set. Review issue #5 (silent JSON parse failures): Changed metadata_config_json parsing in JNI readManifest and readPostCheckpointChanges to throw RuntimeException on malformed JSON instead of silently falling back to empty. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.