fix(cache): use readable origin keys instead of truncated base64#17
Merged
fix(cache): use readable origin keys instead of truncated base64#17
Conversation
The previous scheme encoded origins as the first 8 characters of base64(full URL), which caused all HTTPS registries to collide on "aHR0cHM6" (the base64 of "https://"). New scheme produces readable, collision-resistant keys: - Format: [http~]hostname[~port][~path~segments] - Segments truncated: <=5 chars kept whole, else first 3 + last 2 - HTTPS implicit, only http~ prefix for HTTP origins - npm alias preserved for registry.npmjs.com/org, replicate.npmjs.com Examples: https://registry.npmjs.com -> npm https://packages.example.com/js -> paces.exale.com~js http://localhost:4873 -> http~locst~4873 https://host.jfrog.io/art/api/npm -> host.jfrog.io~art~api~npm Backward compatibility: - Old base64 keys (without . or ~) decode to <legacy:...> - No migration needed; old cache entries become orphans Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous scheme encoded origins as the first 8 characters of base64 (full URL), which caused all HTTPS registries to collide on "aHR0cHM6" (the base64 of "https://").
New scheme produces readable, collision-resistant keys:
pathsegments]Examples:
Backward compatibility: