Merged
Conversation
ThiefMaster
commented
Mar 26, 2021
ThiefMaster
commented
Mar 26, 2021
ThiefMaster
force-pushed
the
search
branch
5 times, most recently
from
b2b1e60 to
e5babc9
Compare
ThiefMaster
force-pushed
the
search
branch
2 times, most recently
from
e5dcc20 to
b919fd9
Compare
ThiefMaster
commented
Apr 22, 2021
Member
Author
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
Just some stuff I noticed while looking over everything -
indico/modules/search/client/js/components/ResultList.module.scss
Outdated
Show resolved
Hide resolved
indico/modules/search/client/js/components/results/File.module.scss
Outdated
Show resolved
Hide resolved
ThiefMaster
force-pushed
the
search
branch
2 times, most recently
from
2ff6f44 to
72d40e2
Compare
ThiefMaster
force-pushed
the
search
branch
3 times, most recently
from
132340e to
933e554
Compare
This is a squashed commit of all the changes in #4067 since that PR got massive over time. Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
Update the sidebar
They are only needed in LiveSync backends, so they fit better in the livesync plugin.
- palette color for highlight (blue instead of orange) - trim keywords - get rid of unused var - ensure root element exists
This reverts commit f195d1d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #4736