Skip to content

[codex] Fix chart edge case rendering#763

Merged
iexitdev merged 1 commit intomasterfrom
codex/easy-win-issue-fixes
Apr 28, 2026
Merged

[codex] Fix chart edge case rendering#763
iexitdev merged 1 commit intomasterfrom
codex/easy-win-issue-fixes

Conversation

@iexitdev
Copy link
Copy Markdown
Contributor

Summary

This PR fixes a set of small chart correctness issues from the open issue backlog:

  • remove the direct lodash dependency by replacing the remaining range usage in ContributionGraph
  • guard shared chart scaling/label calculations against empty, invalid, and non-finite data
  • avoid LineChart crashes when datasets are empty or missing while vertical lines/scrollable dots are enabled
  • prevent LineChart null placeholders in one dataset from inheriting the previous dataset's last rendered point
  • normalize strokeDashArray arrays to SVG-compatible strings before rendering line strokes
  • add a web onClick handler beside the existing SVG press handler for LineChart dots
  • avoid NaN stacked-bar geometry when all stacked values are zero

Fixes #741
Fixes #707
Fixes #744
Fixes #472
Fixes #327
Fixes #743
Fixes #704
Fixes #576
Fixes #609
Fixes #747

Validation

  • npm run typecheck
  • npm run build
  • npm test -- --watch=false --passWithNoTests

Jest has no test files in this repository, so the final command only verifies the test runner exits cleanly with the no-tests setting.

@iexitdev iexitdev merged commit 5b5335e into master Apr 28, 2026
1 check passed
@daxaxelrod
Copy link
Copy Markdown

hey! nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment