Removing appId from API Client#19
Merged
bbala-github merged 6 commits intomasterfrom Dec 9, 2016
Merged
Conversation
manojlds
reviewed
Dec 8, 2016
| ##Usage : | ||
|
|
||
| The client needs to be first instantiated with the appropriate application id and key to be able to use | ||
| The client needs to be first instantiated with the appropriate application key to be able to use |
Member
There was a problem hiding this comment.
Not related to this change, but this reads weird - can you change to something like:
First, the client must be instantiated with the appropriate application key (
appKey)
Contributor
|
@bethleha this is a breaking change, we need to update the version accordingly. |
Contributor
Author
|
@praveenselvam @manojlds @bbala-github @ashwanthkumar @shrechak Code review comments incorporated. Please review and merge this. |
bbala-github
approved these changes
Dec 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@praveenselvam Please review.