Forbid setting force_device_scalars=False#278
Merged
inducer merged 2 commits intoinducer:mainfrom Sep 4, 2024
Merged
Conversation
majosm
force-pushed
the
always-force-device-scalars
branch
3 times, most recently
from
c148497 to
b4b0f1e
Compare
8 tasks
Collaborator
Author
|
Looks like the default value of |
alexfikl
reviewed
Aug 14, 2024
Collaborator
alexfikl
left a comment
alexfikl
left a comment
There was a problem hiding this comment.
This has been deprecated for a long time now, so I'm definitely in favor! 🎉
Owner
|
Very much in favor as well! |
majosm
force-pushed
the
always-force-device-scalars
branch
from
c2ab44f to
b4b0f1e
Compare
Collaborator
Author
|
Ruff errors appear to be unrelated, so I think this is ready for a look. inducer/meshmode#429 and inducer/grudge#358 should probably get merged before this. |
inducer
force-pushed
the
always-force-device-scalars
branch
from
88d3341 to
61e3dfa
Compare
inducer
force-pushed
the
always-force-device-scalars
branch
from
61e3dfa to
74b00d8
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated since 2022, AFAIK no longer needed?
To-do:
force_device_scalars=Falsemeshmode#429force_device_scalarsby default grudge#358