Add concatenate_arrays transformation#717
Merged
Merged
Conversation
isuruf
force-pushed
the
merge_temporary_arrays
branch
from
c9c64e9 to
b769fa0
Compare
inducer
reviewed
Dec 27, 2022
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks for working on this! A few comments below.
kaushikcfd
approved these changes
Dec 28, 2022
isuruf
force-pushed
the
merge_temporary_arrays
branch
2 times, most recently
from
44d31bc to
ec43b99
Compare
isuruf
changed the title
inducer
force-pushed
the
merge_temporary_arrays
branch
from
ec43b99 to
135e6f2
Compare
Owner
|
Reworked this a bit, LGTM now. Thanks! |
inducer
changed the title
concatenate_arrays transformation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for inducer/sumpy#151