Merged
Conversation
Co-authored-by: Andreas Klöckner <inform@tiker.net>
inducer
reviewed
Jan 3, 2021
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks for working on this. LGTM, just a few style things left. FWIW, I looked over my comments in alexfikl#3, and I very much like the direction this has taken.
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
alexfikl
force-pushed
the
tensor-product-refinement
branch
from
df892c4 to
da75962
Compare
Owner
|
LGTM. Thanks for working on this, too! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #70 with some discussion in alexfikl#3.
This PR mostly consolidates the refinement of elements backed by modepy shapes (from inducer/modepy#16). The actual algorithm is not changed (at least in spirit) from the existing one.
Main benefit is that it can now refine cubes, not just simplices!