Skip to content

Fix Lobatto exactness#163

Merged
inducer merged 2 commits intomainfrom
fix-lobatto-exactness
Mar 13, 2026
Merged

Fix Lobatto exactness#163
inducer merged 2 commits intomainfrom
fix-lobatto-exactness

Conversation

@inducer
Copy link
Copy Markdown
Owner

@inducer inducer commented Mar 13, 2026

Closes gh-162

Copilot AI review requested due to automatic review settings March 13, 2026 18:50
@inducer inducer force-pushed the fix-lobatto-exactness branch from ca416e9 to f70fc60 Compare March 13, 2026 18:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the reported Lobatto quadrature exactness metadata (gh-162) by correcting the documented/published degree of exactness to align with the standard Gauss–Lobatto formula for N+1 nodes.

Changes:

  • Update JacobiGaussLobattoQuadrature docstring exactness from 2N-3 to 2N-1.
  • Update the exact_to value passed to the Quadrature base class from 2N-3 to 2N-1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread modepy/quadrature/jacobi_gauss.py
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the reported polynomial exactness for the Jacobi/Legendre Gauss–Lobatto quadrature rules (gh-162) by correcting the documented and exported exact_to degree to match the standard Lobatto formula for N+1 nodes.

Changes:

  • Update Gauss–Lobatto exactness documentation from :math:2N-3 to :math:2N-1 for N+1 nodes.
  • Update JacobiGaussLobattoQuadrature to report exact_to = 2*N - 1 via the base Quadrature initializer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread modepy/quadrature/jacobi_gauss.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@inducer inducer enabled auto-merge (squash) March 13, 2026 19:10
@inducer inducer merged commit 49352a2 into main Mar 13, 2026
20 of 22 checks passed
@inducer inducer deleted the fix-lobatto-exactness branch March 13, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong polynomial order for Gauss Lobatto Quadratures

2 participants